Conversation
zzylol
marked this pull request as draft
September 30, 2026 15:03
zzylol
force-pushed
the
fix/placement-pricing-lag
branch
from
September 30, 2026 15:04
8c8aeda to
e899d10
Compare
zzylol
changed the base branch from
feat/per-state-mixed-placement
to
fix/type-logical-candidates-upfront
September 30, 2026 15:04
zzylol
force-pushed
the
fix/type-logical-candidates-upfront
branch
from
September 30, 2026 15:17
2ce2942 to
aaa7876
Compare
Select the newest complete stored window from one compatible revision at off-grid evaluation times, while retaining exact coverage for stored-only queries. The new +3s process regression failed before the fix and passes afterward. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
fix/placement-pricing-lag
branch
from
September 30, 2026 15:18
e899d10 to
ec8786e
Compare
zzylol
marked this pull request as ready for review
September 30, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #811.
Why
Remote-write revision pinning required a stored window ending exactly at the query evaluation timestamp. Mixed queries between window boundaries fell back before bounded-lag execution could select the latest complete window.
What
Pin one compatible revision with complete stored windows within each mixed binding's configured lag bound (default one slide). Retain only admitted windows; stored-only queries still require exact interval coverage.
Before this PR
A mixed query evaluated three seconds after a window boundary fell back despite a complete stored window within its lag bound.
After this PR
The query fetches raw input at its requested timestamp, combines it with the admitted stored window, and reports the three-second lag. Incomplete newer windows do not shadow complete older windows.
Validation
🤖 Generated with Claude Code
Final stack validation at #809 / Planner
a049a3b: formatting, clippy, workspace library tests, all control-plane tests, and all 30 process tests pass (122.91s).